Skip to content

Commit

Permalink
ACPI: processor: perflib: Eliminate redundant status check
Browse files Browse the repository at this point in the history
One of the "status != AE_NOT_FOUND" checks in
acpi_processor_get_platform_limit() is redundant,
so rearrange the code to eliminate it.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Rafael J. Wysocki committed Mar 8, 2021
1 parent 52af99c commit 2c25fab
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions drivers/acpi/processor_perflib.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,15 @@ static int acpi_processor_get_platform_limit(struct acpi_processor *pr)
* (e.g. 0 = states 0..n; 1 = states 1..n; etc.
*/
status = acpi_evaluate_integer(pr->handle, "_PPC", NULL, &ppc);

if (status != AE_NOT_FOUND)
if (status != AE_NOT_FOUND) {
acpi_processor_ppc_in_use = true;

if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
acpi_handle_warn(pr->handle, "_PPC evaluation failed: %s\n",
acpi_format_exception(status));
return -ENODEV;
if (ACPI_FAILURE(status)) {
acpi_handle_warn(pr->handle,
"_PPC evaluation failed: %s\n",
acpi_format_exception(status));
return -ENODEV;
}
}

pr_debug("CPU %d: _PPC is %d - frequency %s limited\n", pr->id,
Expand Down

0 comments on commit 2c25fab

Please sign in to comment.