Skip to content

Commit

Permalink
pwm: tegra: Assert reset only after the PWM was unregistered
Browse files Browse the repository at this point in the history
The driver is supposed to stay functional until pwmchip_remove()
returns. So the reset must be asserted only after that.

pwmchip_remove() always returns 0, so the return code can be ignored
which keeps the tegra_pwm_remove() a bit simpler.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Uwe Kleine-König authored and Thierry Reding committed Jun 30, 2021
1 parent 3b8b571 commit 2f1a3bd
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/pwm/pwm-tegra.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,11 @@ static int tegra_pwm_remove(struct platform_device *pdev)
{
struct tegra_pwm_chip *pc = platform_get_drvdata(pdev);

pwmchip_remove(&pc->chip);

reset_control_assert(pc->rst);

return pwmchip_remove(&pc->chip);
return 0;
}

#ifdef CONFIG_PM_SLEEP
Expand Down

0 comments on commit 2f1a3bd

Please sign in to comment.