Skip to content

Commit

Permalink
platform/x86: think-lmi: Use min_t() for comparison and assignment
Browse files Browse the repository at this point in the history
Simplify code by using min_t helper macro for logical evaluation
and value assignment. Use the _t variant of min macro since the
variable types are not same.
This issue is identified by coccicheck using the minmax.cocci file.

Signed-off-by: Deepak R Varma <drv@mailo.com>
Link: https://lore.kernel.org/r/Y9QupEMPFoZpWIiM@ubun2204.myguest.virtualbox.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
  • Loading branch information
Deepak R Varma authored and Hans de Goede committed Feb 3, 2023
1 parent bdf2ffb commit 391bb17
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/platform/x86/think-lmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ static int tlmi_get_pwd_settings(struct tlmi_pwdcfg *pwdcfg)
return -EIO;
}

copy_size = obj->buffer.length < sizeof(struct tlmi_pwdcfg) ?
obj->buffer.length : sizeof(struct tlmi_pwdcfg);
copy_size = min_t(size_t, obj->buffer.length, sizeof(struct tlmi_pwdcfg));

memcpy(pwdcfg, obj->buffer.pointer, copy_size);
kfree(obj);

Expand Down

0 comments on commit 391bb17

Please sign in to comment.