Skip to content

Commit

Permalink
drivers/misc/hpilo: Correct panic when an AUX iLO is detected
Browse files Browse the repository at this point in the history
commit eefbc59 upstream.

 Using an uninitialized variable 'devnum' after 'goto out;' was causing
 panic.  Just go ahead and return, we need to ignore AUX iLO devs.

 Oops: 0002 [#1] SMP
   .
   .
   .
 RIP  [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]

Signed-off-by: Mark Rusk <mark.rusk@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Mark Rusk authored and Greg Kroah-Hartman committed Sep 8, 2013
1 parent 2880e37 commit 39d163b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/misc/hpilo.c
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ static int ilo_probe(struct pci_dev *pdev,

/* Ignore subsystem_device = 0x1979 (set by BIOS) */
if (pdev->subsystem_device == 0x1979)
goto out;
return 0;

if (max_ccb > MAX_CCB)
max_ccb = MAX_CCB;
Expand Down Expand Up @@ -899,7 +899,7 @@ static void __exit ilo_exit(void)
class_destroy(ilo_class);
}

MODULE_VERSION("1.4");
MODULE_VERSION("1.4.1");
MODULE_ALIAS(ILO_NAME);
MODULE_DESCRIPTION(ILO_NAME);
MODULE_AUTHOR("David Altobelli <david.altobelli@hp.com>");
Expand Down

0 comments on commit 39d163b

Please sign in to comment.