Skip to content

Commit

Permalink
net: hns3: fix a bug in hns3_driv_to_eth_caps
Browse files Browse the repository at this point in the history
The value of link_modes.advertising and the value of link_modes.supported
is initialized to zero every time in for loop in hns3_driv_to_eth_caps().
But we just want to set specified bit for them. Initialization is
unnecessary. This patch fixes it.

Fixes: 496d03e (net: hns3: Add Ethtool support to HNS3 driver)
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Fuyun Liang authored and David S. Miller committed Nov 3, 2017
1 parent 2b39cab commit 3e1a8f1
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -359,17 +359,12 @@ static void hns3_driv_to_eth_caps(u32 caps, struct ethtool_link_ksettings *cmd,
if (!(caps & hns3_lm_map[i].hns3_link_mode))
continue;

if (is_advertised) {
ethtool_link_ksettings_zero_link_mode(cmd,
advertising);
if (is_advertised)
__set_bit(hns3_lm_map[i].ethtool_link_mode,
cmd->link_modes.advertising);
} else {
ethtool_link_ksettings_zero_link_mode(cmd,
supported);
else
__set_bit(hns3_lm_map[i].ethtool_link_mode,
cmd->link_modes.supported);
}
}
}

Expand Down

0 comments on commit 3e1a8f1

Please sign in to comment.