Skip to content

Commit

Permalink
net: hinic: Make use of the helper function dev_err_probe()
Browse files Browse the repository at this point in the history
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Cai Huoqing authored and David S. Miller committed Sep 16, 2021
1 parent 015a22f commit 4fd3ff3
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/ethernet/huawei/hinic/hinic_main.c
Original file line number Diff line number Diff line change
@@ -1379,10 +1379,8 @@ static int hinic_probe(struct pci_dev *pdev,
{
int err = pci_enable_device(pdev);

if (err) {
dev_err(&pdev->dev, "Failed to enable PCI device\n");
return err;
}
if (err)
return dev_err_probe(&pdev->dev, err, "Failed to enable PCI device\n");

err = pci_request_regions(pdev, HINIC_DRV_NAME);
if (err) {

0 comments on commit 4fd3ff3

Please sign in to comment.