Skip to content

Commit

Permalink
dt-bindings: phy: samsung,ufs-phy: match clock items
Browse files Browse the repository at this point in the history
Below error is detected from dtbs_check. exynos7-ufs-phy is required
symbol clocks otherwise only PLL ref clock is required.

clock-names: ['ref_clk'] is too short

Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220725000249.30509-1-chanho61.park@samsung.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Chanho Park authored and Vinod Koul committed Aug 30, 2022
1 parent 533e133 commit 5517415
Showing 1 changed file with 37 additions and 10 deletions.
47 changes: 37 additions & 10 deletions Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,12 @@ properties:
- const: phy-pma

clocks:
items:
- description: PLL reference clock
- description: symbol clock for input symbol ( rx0-ch0 symbol clock)
- description: symbol clock for input symbol ( rx1-ch1 symbol clock)
- description: symbol clock for output symbol ( tx0 symbol clock)
minItems: 1
maxItems: 4

clock-names:
items:
- const: ref_clk
- const: rx1_symbol_clk
- const: rx0_symbol_clk
- const: tx0_symbol_clk
minItems: 1
maxItems: 4

samsung,pmu-syscon:
$ref: '/schemas/types.yaml#/definitions/phandle-array'
Expand All @@ -62,6 +56,39 @@ required:
- clock-names
- samsung,pmu-syscon

allOf:
- if:
properties:
compatible:
contains:
const: samsung,exynos7-ufs-phy

then:
properties:
clocks:
items:
- description: PLL reference clock
- description: symbol clock for input symbol (rx0-ch0 symbol clock)
- description: symbol clock for input symbol (rx1-ch1 symbol clock)
- description: symbol clock for output symbol (tx0 symbol clock)

clock-names:
items:
- const: ref_clk
- const: rx1_symbol_clk
- const: rx0_symbol_clk
- const: tx0_symbol_clk

else:
properties:
clocks:
items:
- description: PLL reference clock

clock-names:
items:
- const: ref_clk

additionalProperties: false

examples:
Expand Down

0 comments on commit 5517415

Please sign in to comment.