Skip to content

Commit

Permalink
thermal/debugfs: Allow tze_seq_show() to print statistics for invalid…
Browse files Browse the repository at this point in the history
… trips

Commit a6258fd ("thermal/debugfs: Make tze_seq_show() skip invalid
trips and trips with no stats") modified tze_seq_show() to skip invalid
trips, but it overlooked the fact that a trip may become invalid during
a mitigation eposide involving it, in which case its statistics should
still be reported.

For this reason, remove the invalid trip temperature check from the
main loop in tze_seq_show().

The trips that have never been valid will still be skipped after this
change because there are no statistics to report for them.

Fixes: a6258fd ("thermal/debugfs: Make tze_seq_show() skip invalid trips and trips with no stats")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Rafael J. Wysocki committed May 27, 2024
1 parent 9e69acc commit 5a599e1
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/thermal/thermal_debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -802,10 +802,6 @@ static int tze_seq_show(struct seq_file *s, void *v)
const struct thermal_trip *trip = &td->trip;
struct trip_stats *trip_stats;

/* Skip invalid trips. */
if (trip->temperature == THERMAL_TEMP_INVALID)
continue;

/*
* There is no possible mitigation happening at the
* critical trip point, so the stats will be always
Expand Down

0 comments on commit 5a599e1

Please sign in to comment.