Skip to content

Commit

Permalink
ARM: stm32: Don't select DMA unconditionally on STM32MP157C
Browse files Browse the repository at this point in the history
The patch that enabled these had no useful changelog that explains
why it is done, and it causes a build warning:

WARNING: unmet direct dependencies detected for STM32_DMA
  Depends on [n]: DMADEVICES [=n] && (ARCH_STM32 [=y] || COMPILE_TEST [=y])
  Selected by [y]:
  - MACH_STM32MP157 [=y] && ARCH_STM32 [=y] && ARCH_MULTI_V7 [=y]

Generally, platforms should not select arbitrary drivers, so let's
just revert that change.

Fixes: de6037f ("ARM: stm32: Select DMA, DMAMUX and MDMA support on STM32MP157C")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Olof Johansson <olof@lixom.net>
  • Loading branch information
Arnd Bergmann authored and Olof Johansson committed May 25, 2018
1 parent bd6cc4f commit 5ab99d4
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions arch/arm/mach-stm32/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ if ARCH_MULTI_V7

config MACH_STM32MP157
bool "STMicroelectronics STM32MP157"
select STM32_DMA
select STM32_DMAMUX
select STM32_MDMA
default y

endif # ARMv7-A
Expand Down

0 comments on commit 5ab99d4

Please sign in to comment.