Skip to content

Commit

Permalink
sunrpc: Don't do a dst_confirm() on an input routes.
Browse files Browse the repository at this point in the history
xs_udp_data_ready() is operating on received packets, and tries to
do a dst_confirm() on the dst attached to the SKB.

This isn't right, dst confirmation is for output routes, not input
rights.  It's for resetting the timers on the nexthop neighbour entry
for the route, indicating that we've got good evidence that we've
successfully reached it.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jul 5, 2012
1 parent 3c521f2 commit 60d354e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions net/sunrpc/xprtsock.c
Original file line number Diff line number Diff line change
Expand Up @@ -1014,9 +1014,6 @@ static void xs_udp_data_ready(struct sock *sk, int len)

UDPX_INC_STATS_BH(sk, UDP_MIB_INDATAGRAMS);

/* Something worked... */
dst_confirm(skb_dst(skb));

xprt_adjust_cwnd(task, copied);
xprt_complete_rqst(task, copied);

Expand Down

0 comments on commit 60d354e

Please sign in to comment.