Skip to content

Commit

Permalink
fbdev: lxfb: Fix potential divide by zero
Browse files Browse the repository at this point in the history
var->pixclock can be assigned to zero by user. Without proper
check, divide by zero would occur in lx_set_clock.

Error out if var->pixclock is zero.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Wei Chen authored and Helge Deller committed Mar 16, 2023
1 parent d823685 commit 61ac4b8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/video/fbdev/geode/lxfb_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,9 @@ static void get_modedb(struct fb_videomode **modedb, unsigned int *size)

static int lxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
{
if (!var->pixclock)
return -EINVAL;

if (var->xres > 1920 || var->yres > 1440)
return -EINVAL;

Expand Down

0 comments on commit 61ac4b8

Please sign in to comment.