Skip to content

Commit

Permalink
fbdev: intelfb: Fix potential divide by zero
Browse files Browse the repository at this point in the history
Variable var->pixclock is controlled by user and can be assigned
to zero. Without proper check, divide by zero would occur in
intelfbhw_validate_mode and intelfbhw_mode_to_hw.

Error out if var->pixclock is zero.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Wei Chen authored and Helge Deller committed Mar 16, 2023
1 parent 92e2a00 commit d823685
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/video/fbdev/intelfb/intelfbdrv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,9 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,

dinfo = GET_DINFO(info);

if (!var->pixclock)
return -EINVAL;

/* update the pitch */
if (intelfbhw_validate_mode(dinfo, var) != 0)
return -EINVAL;
Expand Down

0 comments on commit d823685

Please sign in to comment.