Skip to content

Commit

Permalink
Revert "serial: amba-pl011: Make sure we initialize the port.lock spi…
Browse files Browse the repository at this point in the history
…nlock"

This reverts commit 8508f4c.

There has been a quick fix against uninitialised lock revealed by
the commit f743061 ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.

Fixes: 8508f4c ("serial: amba-pl011: Make sure we initialize the port.lock spinlock")
Depends-on: f743061 ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200711135346.71171-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andy Shevchenko authored and Greg Kroah-Hartman committed Jul 21, 2020
1 parent 30336ef commit 6a63ba9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/tty/serial/amba-pl011.c
Original file line number Diff line number Diff line change
Expand Up @@ -2607,7 +2607,6 @@ static int pl011_setup_port(struct device *dev, struct uart_amba_port *uap,
uap->port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_AMBA_PL011_CONSOLE);
uap->port.flags = UPF_BOOT_AUTOCONF;
uap->port.line = index;
spin_lock_init(&uap->port.lock);

amba_ports[index] = uap;

Expand Down

0 comments on commit 6a63ba9

Please sign in to comment.