Skip to content

Commit

Permalink
drm/sun4i: Fix error handling
Browse files Browse the repository at this point in the history
'sun4i_layers_init()' returns an error pointer in case of error, not
NULL. So test it with IS_ERR.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
  • Loading branch information
Christophe JAILLET authored and Maxime Ripard committed Nov 2, 2016
1 parent 0df03b4 commit 6c08d7a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/sun4i/sun4i_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ static int sun4i_drv_bind(struct device *dev)

/* Create our layers */
drv->layers = sun4i_layers_init(drm);
if (!drv->layers) {
if (IS_ERR(drv->layers)) {
dev_err(drm->dev, "Couldn't create the planes\n");
ret = -EINVAL;
goto free_drm;
Expand Down

0 comments on commit 6c08d7a

Please sign in to comment.