Skip to content

Commit

Permalink
IB/srp: Use print_hex_dump()
Browse files Browse the repository at this point in the history
Replace an open-coded dump of the receive buffer with a call to
print_hex_dump().

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Bart Van Assche authored and Roland Dreier committed Aug 4, 2010
1 parent 589643b commit 7a70081
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions drivers/infiniband/ulp/srp/ib_srp.c
Original file line number Diff line number Diff line change
Expand Up @@ -879,21 +879,10 @@ static void srp_handle_recv(struct srp_target_port *target, struct ib_wc *wc)
opcode = *(u8 *) iu->buf;

if (0) {
int i;

shost_printk(KERN_ERR, target->scsi_host,
PFX "recv completion, opcode 0x%02x\n", opcode);

for (i = 0; i < wc->byte_len; ++i) {
if (i % 8 == 0)
printk(KERN_ERR " [%02x] ", i);
printk(" %02x", ((u8 *) iu->buf)[i]);
if ((i + 1) % 8 == 0)
printk("\n");
}

if (wc->byte_len % 8)
printk("\n");
print_hex_dump(KERN_ERR, "", DUMP_PREFIX_OFFSET, 8, 1,
iu->buf, wc->byte_len, true);
}

switch (opcode) {
Expand Down

0 comments on commit 7a70081

Please sign in to comment.