Skip to content

Commit

Permalink
ethernet/emac/sysrq: fix inconstistent help message of sysrq key
Browse files Browse the repository at this point in the history
Currently help message of /proc/sysrq-trigger highlight its upper-case
characters, like below:

      SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
      memory-full-oom-kill(F) kill-all-tasks(I) ...

this would confuse user trigger sysrq by upper-case character, which is
inconsistent with the real lower-case character registed key.

This inconsistent help message will also lead more confused when
26 upper-case letters put into use in future.

This patch ethernet emac sysrq key: "emac(c)"

Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
Cc: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
zhangwei(Jovi) authored and Linus Torvalds committed May 1, 2013
1 parent 5452c7f commit 7b6b99a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/ibm/emac/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ static void emac_sysrq_handler(int key)

static struct sysrq_key_op emac_sysrq_op = {
.handler = emac_sysrq_handler,
.help_msg = "emaC",
.help_msg = "emac(c)",
.action_msg = "Show EMAC(s) status",
};

Expand Down

0 comments on commit 7b6b99a

Please sign in to comment.