Skip to content

Commit

Permalink
net: qede: use extack in qede_parse_actions()
Browse files Browse the repository at this point in the history
Convert DP_NOTICE/DP_INFO to NL_SET_ERR_MSG_MOD.

Keep edev around for use with QEDE_RSS_COUNT().

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508143404.95901-15-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Asbjørn Sloth Tønnesen authored and Jakub Kicinski committed May 11, 2024
1 parent d2a437e commit 8415487
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/ethernet/qlogic/qede/qede_filter.c
Original file line number Diff line number Diff line change
Expand Up @@ -1671,7 +1671,7 @@ static int qede_parse_actions(struct qede_dev *edev,
int i;

if (!flow_action_has_entries(flow_action)) {
DP_NOTICE(edev, "No actions received\n");
NL_SET_ERR_MSG_MOD(extack, "No actions received");
return -EINVAL;
}

Expand All @@ -1687,7 +1687,8 @@ static int qede_parse_actions(struct qede_dev *edev,
break;

if (act->queue.index >= QEDE_RSS_COUNT(edev)) {
DP_INFO(edev, "Queue out-of-bounds\n");
NL_SET_ERR_MSG_MOD(extack,
"Queue out-of-bounds");
return -EINVAL;
}
break;
Expand Down

0 comments on commit 8415487

Please sign in to comment.