Skip to content

Commit

Permalink
riscv: hibernate: remove WARN_ON in save_processor_state
Browse files Browse the repository at this point in the history
During hibernation or restoration, freeze_secondary_cpus
checks num_online_cpus via BUG_ON, and the subsequent
save_processor_state also does the checking with WARN_ON.

In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
is not defined, but the sole possible condition to disable
CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
We also don't have to check it in save_processor_state.

So remove the unnecessary checking in save_processor_state.

Fixes: c031721 ("RISC-V: Add arch functions to support hibernation/suspend-to-disk")
Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230609075049.2651723-4-songshuaishuai@tinylab.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
  • Loading branch information
Song Shuai authored and Palmer Dabbelt committed Jun 23, 2023
1 parent b5e13f3 commit 91afbaa
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/riscv/kernel/hibernate.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ int pfn_is_nosave(unsigned long pfn)

void notrace save_processor_state(void)
{
WARN_ON(num_online_cpus() != 1);
}

void notrace restore_processor_state(void)
Expand Down

0 comments on commit 91afbaa

Please sign in to comment.