Skip to content

Commit

Permalink
arm64: dts: meson: disable pad bias for mmc pinmuxes
Browse files Browse the repository at this point in the history
In some cases (such as a boot from SPI) the bootloader or the ROM code may
leave a bias pull-down on the mmc pins. If so the MMC will fail during the
initialisation.

Explicitly disabling the pinmux solves the problem.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
  • Loading branch information
Jerome Brunet authored and Kevin Hilman committed Nov 29, 2018
1 parent 06096d7 commit 96a1369
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions arch/arm64/boot/dts/amlogic/meson-axg.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@
"emmc_cmd",
"emmc_ds";
function = "emmc";
bias-disable;
};
};

Expand Down Expand Up @@ -533,6 +534,7 @@
"sdio_cmd",
"sdio_clk";
function = "sdio";
bias-disable;
};
};

Expand Down
4 changes: 4 additions & 0 deletions arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -363,13 +363,15 @@
"emmc_cmd",
"emmc_clk";
function = "emmc";
bias-disable;
};
};

emmc_ds_pins: emmc-ds {
mux {
groups = "emmc_ds";
function = "emmc";
bias-disable;
};
};

Expand Down Expand Up @@ -416,6 +418,7 @@
"sdcard_cmd",
"sdcard_clk";
function = "sdcard";
bias-disable;
};
};

Expand All @@ -436,6 +439,7 @@
"sdio_cmd",
"sdio_clk";
function = "sdio";
bias-disable;
};
};

Expand Down
4 changes: 4 additions & 0 deletions arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -310,13 +310,15 @@
"emmc_cmd",
"emmc_clk";
function = "emmc";
bias-disable;
};
};

emmc_ds_pins: emmc-ds {
mux {
groups = "emmc_ds";
function = "emmc";
bias-disable;
};
};

Expand Down Expand Up @@ -363,6 +365,7 @@
"sdcard_cmd",
"sdcard_clk";
function = "sdcard";
bias-disable;
};
};

Expand All @@ -383,6 +386,7 @@
"sdio_cmd",
"sdio_clk";
function = "sdio";
bias-disable;
};
};

Expand Down

0 comments on commit 96a1369

Please sign in to comment.