Skip to content

Commit

Permalink
[ARM] omap: fix usecount decrement bug
Browse files Browse the repository at this point in the history
Based upon a patch from Paul Walmsley <paul@pwsan.com>:

 If _omap2_clk_enable() fails, the clock's usecount must be decremented
 by one no matter whether the clock has a parent or not.

but reorganised a bit.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Feb 8, 2009
1 parent be5f34b commit a7f8c59
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions arch/arm/mach-omap2/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,30 +419,30 @@ int omap2_clk_enable(struct clk *clk)
int ret = 0;

if (clk->usecount++ == 0) {
if (clk->parent)
if (clk->parent) {
ret = omap2_clk_enable(clk->parent);

if (ret != 0) {
clk->usecount--;
return ret;
if (ret)
goto err;
}

if (clk->clkdm)
omap2_clkdm_clk_enable(clk->clkdm, clk);

ret = _omap2_clk_enable(clk);

if (ret != 0) {
if (ret) {
if (clk->clkdm)
omap2_clkdm_clk_disable(clk->clkdm, clk);

if (clk->parent) {
if (clk->parent)
omap2_clk_disable(clk->parent);
clk->usecount--;
}

goto err;
}
}
return ret;

err:
clk->usecount--;
return ret;
}

Expand Down

0 comments on commit a7f8c59

Please sign in to comment.