Skip to content

Commit

Permalink
sis190: scheduling while atomic error
Browse files Browse the repository at this point in the history
sis190_tx_timeout
-> sis190_hw_start
   -> sis190_soft_reset
      -> msleep *splat*

PCI transactions are correctly flushed here.
The msleep() is probably useless.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: K.M. Liu <kmliu@sis.com.tw>
  • Loading branch information
Francois Romieu authored and David S. Miller committed Jan 23, 2008
1 parent 7bf3f23 commit b334349
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/sis190.c
Original file line number Diff line number Diff line change
Expand Up @@ -847,10 +847,8 @@ static void sis190_soft_reset(void __iomem *ioaddr)
{
SIS_W32(IntrControl, 0x8000);
SIS_PCI_COMMIT();
msleep(1);
SIS_W32(IntrControl, 0x0);
sis190_asic_down(ioaddr);
msleep(1);
}

static void sis190_hw_start(struct net_device *dev)
Expand Down

0 comments on commit b334349

Please sign in to comment.