Skip to content

Commit

Permalink
MIPS: smp: Warn on too early irq enable
Browse files Browse the repository at this point in the history
Just to catch a potential issue.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: David Daney <david.daney@cavium.com>
Acked-by: David Daney <david.daney@cavium.com>
Patchwork: https://patchwork.linux-mips.org/patch/3852/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Yong Zhang authored and Ralf Baechle committed Jul 19, 2012
1 parent b9a09a0 commit b789ad6
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions arch/mips/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void)

synchronise_count_slave();

/*
* irq will be enabled in ->smp_finish(), enabling it too early
* is dangerous.
*/
WARN_ON_ONCE(!irqs_disabled());
mp_ops->smp_finish();

cpu_idle();
Expand Down

0 comments on commit b789ad6

Please sign in to comment.