Skip to content

Commit

Permalink
MIPS: call set_cpu_online() on cpu being brought up with irq disabled
Browse files Browse the repository at this point in the history
To prevent a problem as commit 5fbd036 [sched: Cleanup cpu_active madness]
and commit 2baab4e [sched: Fix select_fallback_rq() vs cpu_active/cpu_online]
try to resolve, move set_cpu_online() to the brought up CPU and with irq
disabled.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: David Daney <david.daney@cavium.com>
Acked-by: David Daney <david.daney@cavium.com>
Patchwork: https://patchwork.linux-mips.org/patch/3851/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Yong Zhang authored and Ralf Baechle committed Jul 19, 2012
1 parent 5309bda commit b9a09a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/mips/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ asmlinkage __cpuinit void start_secondary(void)

notify_cpu_starting(cpu);

set_cpu_online(cpu, true);

set_cpu_sibling_map(cpu);

cpu_set(cpu, cpu_callin_map);
Expand Down Expand Up @@ -197,8 +199,6 @@ int __cpuinit __cpu_up(unsigned int cpu, struct task_struct *tidle)
while (!cpu_isset(cpu, cpu_callin_map))
udelay(100);

set_cpu_online(cpu, true);

return 0;
}

Expand Down

0 comments on commit b9a09a0

Please sign in to comment.