Skip to content

Commit

Permalink
Revert "tty: serial: add missing spin_lock_init for SiFive serial con…
Browse files Browse the repository at this point in the history
…sole"

This reverts commit 17b4efd.

There has been a quick fix against uninitialised lock revealed by
the commit f743061 ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.

Fixes: 17b4efd ("tty: serial: add missing spin_lock_init for SiFive serial console")
Depends-on: f743061 ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200711135346.71171-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andy Shevchenko authored and Greg Kroah-Hartman committed Jul 21, 2020
1 parent 6a63ba9 commit c6e45ae
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/tty/serial/sifive.c
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,6 @@ console_initcall(sifive_console_init);

static void __ssp_add_console_port(struct sifive_serial_port *ssp)
{
spin_lock_init(&ssp->port.lock);
sifive_serial_console_ports[ssp->port.line] = ssp;
}

Expand Down

0 comments on commit c6e45ae

Please sign in to comment.