Skip to content

Commit

Permalink
Revert "serial: imx: Initialize lock for non-registered console"
Browse files Browse the repository at this point in the history
This reverts commit 8f065ac.

There has been a quick fix against uninitialised lock revealed by
the commit f743061 ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.

Fixes: 8f065ac ("serial: imx: Initialize lock for non-registered console")
Depends-on: f743061 ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200711135346.71171-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andy Shevchenko authored and Greg Kroah-Hartman committed Jul 21, 2020
1 parent c6e45ae commit dfe51d9
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/tty/serial/imx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2406,9 +2406,6 @@ static int imx_uart_probe(struct platform_device *pdev)
}
}

/* We need to initialize lock even for non-registered console */
spin_lock_init(&sport->port.lock);

imx_uart_ports[sport->port.line] = sport;

platform_set_drvdata(pdev, sport);
Expand Down

0 comments on commit dfe51d9

Please sign in to comment.