Skip to content

Commit

Permalink
Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"
Browse files Browse the repository at this point in the history
This reverts commit 058a38a.

It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in
an interrupt handler as the interrupt handler itself would be called in a
process context if PREEMPT_RT is enabled. So revert the patch.

Cc: stable@vger.kernel.org # for 6.8
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20240403051341.3534650-1-wentong.wu@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sakari Ailus authored and Greg Kroah-Hartman committed Apr 11, 2024
1 parent 26ac2df commit e3dc66d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/misc/mei/vsc-tp.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,15 +419,15 @@ static irqreturn_t vsc_tp_isr(int irq, void *data)

atomic_inc(&tp->assert_cnt);

wake_up(&tp->xfer_wait);

return IRQ_WAKE_THREAD;
}

static irqreturn_t vsc_tp_thread_isr(int irq, void *data)
{
struct vsc_tp *tp = data;

wake_up(&tp->xfer_wait);

if (tp->event_notify)
tp->event_notify(tp->event_notify_context);

Expand Down

0 comments on commit e3dc66d

Please sign in to comment.