Skip to content

Commit

Permalink
xfs: fix scrub stats file permissions
Browse files Browse the repository at this point in the history
When the kernel is in lockdown mode, debugfs will only show files that
are world-readable and cannot be written, mmaped, or used with ioctl.
That more or less describes the scrub stats file, except that the
permissions are wrong -- they should be 0444, not 0644.  You can't write
the stats file, so the 0200 makes no sense.

Meanwhile, the clear_stats file is only writable, but it got mode 0400
instead of 0200, which would make more sense.

Fix both files so that they make sense.

Fixes: d7a74ca ("xfs: track usage statistics of online fsck")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
  • Loading branch information
Darrick J. Wong authored and Chandan Babu R committed Feb 26, 2024
1 parent 1e5efd7 commit e610e85
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/xfs/scrub/stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -331,9 +331,9 @@ xchk_stats_register(
if (!cs->cs_debugfs)
return;

debugfs_create_file("stats", 0644, cs->cs_debugfs, cs,
debugfs_create_file("stats", 0444, cs->cs_debugfs, cs,
&scrub_stats_fops);
debugfs_create_file("clear_stats", 0400, cs->cs_debugfs, cs,
debugfs_create_file("clear_stats", 0200, cs->cs_debugfs, cs,
&clear_scrub_stats_fops);
}

Expand Down

0 comments on commit e610e85

Please sign in to comment.