Skip to content

Commit

Permalink
arm64: define BUG() instruction without CONFIG_BUG
Browse files Browse the repository at this point in the history
This mirrors commit e9c38ce ("ARM: 8455/1: define __BUG as
asm(BUG_INSTR) without CONFIG_BUG") to make the behavior of
arm64 consistent with arm and x86, and avoids lots of warnings in
randconfig builds, such as:

kernel/seccomp.c: In function '__seccomp_filter':
kernel/seccomp.c:666:1: error: no return statement in function returning non-void [-Werror=return-type]

Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
  • Loading branch information
Arnd Bergmann authored and Catalin Marinas committed Mar 22, 2017
1 parent c651aae commit f13d52c
Showing 1 changed file with 19 additions and 14 deletions.
33 changes: 19 additions & 14 deletions arch/arm64/include/asm/bug.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@

#include <asm/brk-imm.h>

#ifdef CONFIG_GENERIC_BUG
#define HAVE_ARCH_BUG

#ifdef CONFIG_DEBUG_BUGVERBOSE
#define _BUGVERBOSE_LOCATION(file, line) __BUGVERBOSE_LOCATION(file, line)
#define __BUGVERBOSE_LOCATION(file, line) \
Expand All @@ -36,28 +33,36 @@
#define _BUGVERBOSE_LOCATION(file, line)
#endif

#define _BUG_FLAGS(flags) __BUG_FLAGS(flags)
#ifdef CONFIG_GENERIC_BUG

#define __BUG_FLAGS(flags) asm volatile ( \
#define __BUG_ENTRY(flags) \
".pushsection __bug_table,\"a\"\n\t" \
".align 2\n\t" \
"0: .long 1f - 0b\n\t" \
_BUGVERBOSE_LOCATION(__FILE__, __LINE__) \
".short " #flags "\n\t" \
".popsection\n" \
\
"1: brk %[imm]" \
:: [imm] "i" (BUG_BRK_IMM) \
)
"1: "
#else
#define __BUG_ENTRY(flags) ""
#endif

#define __BUG_FLAGS(flags) \
asm volatile ( \
__BUG_ENTRY(flags) \
"brk %[imm]" :: [imm] "i" (BUG_BRK_IMM) \
);

#define BUG() do { \
_BUG_FLAGS(0); \
unreachable(); \

#define BUG() do { \
__BUG_FLAGS(0); \
unreachable(); \
} while (0)

#define __WARN_TAINT(taint) _BUG_FLAGS(BUGFLAG_TAINT(taint))
#define __WARN_TAINT(taint) \
__BUG_FLAGS(BUGFLAG_TAINT(taint))

#endif /* ! CONFIG_GENERIC_BUG */
#define HAVE_ARCH_BUG

#include <asm-generic/bug.h>

Expand Down

0 comments on commit f13d52c

Please sign in to comment.