Skip to content

Commit

Permalink
soc: qcom: rpmh-rsc: Fold WARN_ON() into if condition
Browse files Browse the repository at this point in the history
Move the WARN_ON() into the if condition so the compiler can see that
the branch is unlikely() and possibly optimize it better.

Cc: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20200521060425.24285-4-swboyd@chromium.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
  • Loading branch information
Stephen Boyd authored and Bjorn Andersson committed Mar 12, 2021
1 parent a077662 commit f2590e4
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/soc/qcom/rpmh-rsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,8 @@ static irqreturn_t tcs_tx_done(int irq, void *p)

for_each_set_bit(i, &irq_status, BITS_PER_TYPE(u32)) {
req = get_req_from_tcs(drv, i);
if (!req) {
WARN_ON(1);
if (WARN_ON(!req))
goto skip;
}

err = 0;
for (j = 0; j < req->num_cmds; j++) {
Expand Down

0 comments on commit f2590e4

Please sign in to comment.