Skip to content

Commit

Permalink
xen-pciback: First reset, then free.
Browse files Browse the repository at this point in the history
We were doing the operations of freeing and reset in the wrong
order. Granted nothing broke because the reset functions just
set bar->which = 0.

But nonethless this was incorrect.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
  • Loading branch information
Konrad Rzeszutek Wilk committed May 23, 2014
1 parent 8899035 commit fcb8ce9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/xen/xen-pciback/pci_stub.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,8 @@ void pcistub_put_pci_dev(struct pci_dev *dev)
xen_pcibk_reset_device(dev);

/* And cleanup up our emulated fields. */
xen_pcibk_config_free_dyn_fields(dev);
xen_pcibk_config_reset_dev(dev);
xen_pcibk_config_free_dyn_fields(dev);

xen_unregister_device_domain_owner(dev);

Expand Down

0 comments on commit fcb8ce9

Please sign in to comment.