Skip to content

Commit

Permalink
drm/xe/vf: Don't check CTC_MODE[0] if VF
Browse files Browse the repository at this point in the history
Starting from commit 18778b5 ("drm/xe: Eliminate usage of
TIMESTAMP_OVERRIDE") we access the CTC_MODE register only to warn
if it has undocumented value.  There is no point in doing that on
the VF driver.  While here, move this check to a helper function.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250311114042.1954-2-michal.wajdeczko@intel.com
  • Loading branch information
Michal Wajdeczko committed Mar 12, 2025
1 parent f990c11 commit fce3fb7
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions drivers/gpu/drm/xe/xe_gt_clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,8 @@ static u32 get_crystal_clock_freq(u32 rpm_config_reg)
}
}

int xe_gt_clock_init(struct xe_gt *gt)
static void check_ctc_mode(struct xe_gt *gt)
{
u32 c0 = xe_mmio_read32(&gt->mmio, RPM_CONFIG0);
u32 freq = 0;

/*
* CTC_MODE[0] = 1 is definitely not supported for Xe2 and later
* platforms. In theory it could be a valid setting for pre-Xe2
Expand All @@ -57,7 +54,17 @@ int xe_gt_clock_init(struct xe_gt *gt)
*/
if (xe_mmio_read32(&gt->mmio, CTC_MODE) & CTC_SOURCE_DIVIDE_LOGIC)
xe_gt_warn(gt, "CTC_MODE[0] is set; this is unexpected and undocumented\n");
}

int xe_gt_clock_init(struct xe_gt *gt)
{
u32 freq;
u32 c0;

if (!IS_SRIOV_VF(gt_to_xe(gt)))
check_ctc_mode(gt);

c0 = xe_mmio_read32(&gt->mmio, RPM_CONFIG0);
freq = get_crystal_clock_freq(c0);

/*
Expand Down

0 comments on commit fce3fb7

Please sign in to comment.