Skip to content

Commit

Permalink
mxqd: Remove superfluous "unknown pid returned" warning
Browse files Browse the repository at this point in the history
Currently mxqd emits a warning if a child process, which is not
associated to a pid of a running job, finishes.

With the previous changes, when a job is killed by SIGKILL, we correctly
avoid to kill the reaper process so that the job is finished normally
via fspool. Because of that change it now happens more often that a job
is already done for mxqd when the reaper process terminates normally a
little later. So the condition that we see a terminating child, which is
not related to a running job, is expected behaviour. Remove the warning.

Previously we had "reaper died" messages in the logfile when mxqd sent a
KILL signal to a job, because it  killed the reaper with it.
  • Loading branch information
donald committed Aug 24, 2021
1 parent a332670 commit 28c431c
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions mxqd.c
Original file line number Diff line number Diff line change
Expand Up @@ -2412,13 +2412,6 @@ int catchall(struct mxq_server *server)

jlist = server_get_job_list_by_pid(server, siginfo.si_pid);
if (!jlist) {
mx_log_warning("unknown pid returned.. si_pid=%d si_uid=%d si_code=%d si_status=%d getpgid(si_pid)=%d getsid(si_pid)=%d",
siginfo.si_pid,
siginfo.si_uid,
siginfo.si_code,
siginfo.si_status,
getpgid(siginfo.si_pid),
getsid(siginfo.si_pid));
/* collect child, ignore status */
pid = waitpid(siginfo.si_pid, NULL, WNOHANG);
if (pid != siginfo.si_pid)
Expand Down

0 comments on commit 28c431c

Please sign in to comment.