Fix memory leak on error path

mariux64 · Apr 2, 2022 · 4a4ed5b · 4a4ed5b
1 parent 91b1993
commit 4a4ed5b
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/mx_proc.c b/mx_proc.c
@@ -89,13 +89,11 @@ int mx_proc_pid_stat(struct mx_proc_pid_stat **pps, pid_t pid)
 
     pstat = *pps;
     if (!pstat)
-        pstat = mx_calloc_forever(1, sizeof(*pstat));
+        *pps = pstat = mx_calloc_forever(1, sizeof(*pstat));
 
     res = mx_proc_pid_stat_read(pstat, "/proc/%d/stat", pid);
     if (res < 0)
         return res;
-
-    *pps = pstat;
     return 0;
 }
 
@@ -370,9 +368,10 @@ int mx_proc_tree(struct mx_proc_tree **newtree)
 
         pps = NULL;
         res = mx_proc_pid_stat(&pps, pid);
-        if (res < 0)
+        if (res < 0) {
+            free(pps);
             continue;
-
+        }
         mx_proc_tree_add(pt, pps);
     }
     free(namelist);