mxqd: Do not execute invalid job.argv_str commands.

This fixes issue #13
mariux64 · Jun 16, 2015 · b6ef9fa · b6ef9fa
1 parent f3d826b
commit b6ef9fa
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/mxqd.c b/mxqd.c
@@ -960,7 +960,14 @@ unsigned long start_job(struct mxq_group_list *group)
         }
 
 
-        char **argv = str_to_strvec(mxqjob.job_argv_str);
+        argv = str_to_strvec(mxqjob.job_argv_str);
+        if (!argv) {
+            mx_log_err("job=%s(%d):%lu:%lu Can't recaculate commandline. str_to_strvev(%s) failed: %m",
+                group->group.user_name, group->group.user_uid, group->group.group_id, mxqjob.job_id,
+                mxqjob.job_argv_str);
+            _exit(EX__MAX + 1);
+        }
+
         execvp(argv[0], argv);
         mx_log_err("job=%s(%d):%lu:%lu execvp(\"%s\", ...): %m",
             group->group.user_name, group->group.user_uid, group->group.group_id, mxqjob.job_id,