-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mxqd: unlink bad (left over) fspool files, so we don't try them over …
…and over
- Loading branch information
Showing
1 changed file
with
2 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1864,6 +1864,7 @@ static int fspool_process_file(struct mxq_server *server,char *filename, uint64_ | |
jlist = server_remove_job_list_by_job_id(server, job_id); | ||
if (!jlist) { | ||
mx_log_warning("fspool_process_file: %s : job unknown on server", filename); | ||
unlink(filename); | ||
This comment has been minimized.
Sorry, something went wrong. |
||
return -(errno=ENOENT); | ||
} | ||
|
||
|
@@ -1873,6 +1874,7 @@ static int fspool_process_file(struct mxq_server *server,char *filename, uint64_ | |
filename, | ||
job->job_id, | ||
job_id); | ||
unlink(filename); | ||
This comment has been minimized.
Sorry, something went wrong.
mariux
Contributor
|
||
return -(errno=EINVAL); | ||
} | ||
|
||
|
second server running on same host might fuck things up really really bad if you just unlink here. better limit amount of warning messages. but this is a warning for a reason. so admins can unlink if they know what they are doing.. better check job in database and unlink after updating information.