mxqdump: Dump all jobs from group by default without filtering

[pmenzel]

Currently, mxqdump -j -g ID will only list running jobs, which is not very clear from the usage information. The default should be changed, that if no --status/-s switch is passed, that all jobs are shown.

[niclas]

mxqsub (headline) or mxqdump (description)?

[niclas]

To me it looks clear here.

Whether it should be changed is a question for @wwwutz and @donald.

[pmenzel]

To me it reads like, that only if -s is passed, the default running is used. If no -s is passed, I wouldn’t expect the status to be limited.

[donald]

As discussed: Maybe we shouldn't change the current behavior and surprise users who got used to it, but provide a way to list all jobs ( e.g. -g NNN -s all ) and (try to) improve the usage string.

[pmenzel]

In mxqdump.c there is

mxq/mxqdump.c

Lines 744 to 773 in 66aeeb6

	} else if (arg_jobs) {
	if (UINT64_HASVALUE(arg_group_id)) {
	if (arg_all) {
	mx_log_debug("DO: print all jobs in group_id=%lu", arg_group_id);
	cnt = dump_jobs(mysql, arg_group_id, UINT64_ALL, UINT64_ALL);
	if (!cnt)
	mx_log_notice("There are no jobs in group '%lu'.", arg_group_id);
	} else {
	mx_log_debug("DO: print jobs in group_id=%lu with status='%s(%lu)'",
	arg_group_id, mxq_job_status_to_name(arg_status), arg_status);
	cnt = dump_jobs(mysql, arg_group_id, arg_status, UINT64_ALL);
	if (!cnt)
	mx_log_notice("There are no jobs with status '%s' in group '%lu'.", mxq_job_status_to_name(arg_status), arg_group_id);
	}
	} else {
	if (arg_all) {
	mx_log_debug("DO: print all running jobs");
	dump_jobs(mysql, UINT64_ALL, MXQ_JOB_STATUS_RUNNING, UINT64_ALL);
	} else {
	mx_log_debug("DO: print MY running jobs");
	cnt = dump_jobs(mysql, UINT64_ALL, MXQ_JOB_STATUS_RUNNING, arg_uid);
	if (!cnt) {
	if (arg_uid == ruid)
	mx_log_notice("You do not have any jobs running on the cluster.");
	else
	mx_log_notice("No running jobs for user with uid '%lu'.", arg_uid);
	}
	}
	}

suggesting, that -a can also be used with jobs-options. When -g/--group-id is specified status is unfiltered. When -u/--user is specified the jobs are filtered on status running again. Very confusing.

[donald]

• Dump all jobs from group by default without filtering
• We said, no we won't change the default, but provide a way to dump all jobs from group
• @niclas discovered that that optional already exists, and so just updated the usage to document it.

So is the issue fixed now? Does the usage show how to dump all jobs of a group and does it work?

I don't understand the last comment. Is that part of the "dump all jobs from group" Problem or a new issue? Are there other "hidden" options which need to be documented in the usage string? Is just the code ugly?

Very confusing.

Agreed.