Rename option --threads to --processors #107
Conversation
--group-id was former used for --group-name. That prohibited the use of --group-id for -g.
|
I do not understand “--group-id was former used for --group-name. That prohibited the use of --group-id for -g.”. Please give an exact command, which does not work. |
mxqsub.c
Outdated
| @@ -904,9 +897,11 @@ int main(int argc, char *argv[]) | |||
| } | |||
| break; | |||
|
|
|||
| case 1: | |||
| mx_log_warning("option '--threads' is deprecated. please use '--processors' or '-j' in future calls."); | |||
There was a problem hiding this comment.
- Indentation incorrect?
- Please use …
- Maybe: option '--threads' was renamed to '--processors' and is deprecated. Please update your scripts.
There was a problem hiding this comment.
- I'll fix that.
- & 3. could be a knew pull request since I'm using the current style of the code. Therefore, I dislike to change that and leave the rest of the code.
--group-id was used in former versions as option which is now --group-name but also the current -g has the long option --group-id. Thus, if you use --group-id, you'll maybe get the --group-name behavior. In any case the behavior depends on the order in which the arguments are listed in the source code. That's unacceptable. |
niclas
force-pushed
the
rename-option-threads-to-processors
branch
from
2bb1b78
to
048d25b
Compare
There was a problem hiding this comment.
Good.
Side note: Maybe we should s/threads/processors/ in web/pages/mxq/mxq.in and https://twiki.molgen.mpg.de/foswiki/Edv/MarIuX64ClusterHowTo as well to avoid confusing users.
|
So may I ask out of the loop why I have to rewrite my submit-scripts ? Why even bother ? If it silently eats "--threads"that'll be ok with me. Why warn ? I you call something deprecated you should be preparing for a reuse of the option. I'd prefer not to rewrite all my scripts just because upstream does things like this. so: make it run silently, no warning, no docs. |
I suggested to emit a deprecated warning. But on a second thought I agree that we should accept --threads without warning. |
niclas
force-pushed
the
rename-option-threads-to-processors
branch
from
048d25b
to
95f4a8e
Compare
|
But now |
|
Should have done that at night. I just wasn't concentrated. |
niclas
force-pushed
the
rename-option-threads-to-processors
branch
from
95f4a8e
to
32fd00d
Compare
This fixes #88.