Fix spelling #116
Merged
Fix spelling #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donald
requested changes
Dec 16, 2021
Exception: (UVM global queu) > comm is 16 bytes (including the \0), so 15 characters. So as an > example of /proc/stat, this was actually right :-)
pmenzel
force-pushed
the
fix-spelling
branch
from
c0cc3c2
to
8a8c1ab
Compare
donald
requested changes
Dec 17, 2021
pmenzel
force-pushed
the
fix-spelling
branch
from
8a8c1ab
to
1731eaf
Compare
|
Sorry, accidentally push to master, causing GitHub to mark this as resolved. I reverted the old state and re-opened the merge/pull request. |
|
No commits here? I'm only on mobile phone today, so I'm a bit disabled and can't investigate. |
pmenzel
force-pushed
the
fix-spelling
branch
from
1731eaf
to
7c86fbc
Compare
pmenzel
force-pushed
the
fix-spelling
branch
from
1731eaf
to
03bd205
Compare
|
Sorry, looks like, it’s not so easy to re-open a merge/pull request. |
mariux
reviewed
Dec 17, 2021
mx_proc.c
Outdated
Comment on lines
463
to
464
| char linebuf[256]; // "2147483647 (max128chars) X 2147483647 " = 156 | ||
| char linebuf[64]; // "2147483647 (max15chars) X 2147483647 " = 43 | ||
|
|
There was a problem hiding this comment.
comm being 15 seems like a very wrong assumption ;) also not scope of fixing spelling ;)
kworker/4:0H-events_highpri is a valid value in there and is longer than 15.. so that those are truncated to 16 (not 15) is out of date documentation i assume..
also why safe minimum amount of bytes and risk failure ;)
pmenzel
force-pushed
the
fix-spelling
branch
from
1731eaf
to
03bd205
Compare
|
Thank you all for the review and comments. Let’s split the controversial commit out: #117. |
donald
approved these changes
Dec 17, 2021
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.