mxqd_control: account for orphaned groups #47
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmenzel
changed the title
|
Looks reasonable. Nit: I think it’s account for smth.. |
The count of running jobs and threads of a group were not deducted from the counters the server keeps for the user and the cluster. This lead to wrong scheduling, as users were thought to have more running jobs than they really had. Add code to maintain the global counters.
donald
force-pushed
the
fix-counter-orphaned
branch
from
d897a2a
to
4d90259
Compare
|
amended commit message |
|
seems legit... it should be updated while updating group from database... but if group is orphaned the update might or might not have happened.. but this would not matter since global counters would be added right before removing them again while removing the group and else the counter might be 0 in this case anyway... so without testing just by logic.... yes, should be fine ;) counter leak.. ;) fast leak with fast jobs and slower with long running jobs.. ;) thx for fixing.. ;) |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count of running jobs and threads of a group were
not deducted from the counters the server keeps for the user
and the cluster.
This lead to wrong scheduling, as users were thought to have more
running jobs than they really had.
Add code to maintain the global counters.