Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cgi script currently only needs read-only access to the database. With this change, the cgi script uses another mysql default file which is assuemed to contain read-only credentials and can be provided public readable. This enables the webserver to run without special privileges.
Module CGI already exports a menu sub. Avoid redefinition warning in server log.
By default the groups page shows finished groups for the last seven days. This patch allows the number of days be overridden by a query parameter "days" This feature was first implemented by Peter in his working copy, but his implementation is different, that it limits the time range for active groups as well.
If the group table is constrained by username, show that in the header line.
Donald: Took this from Peter although I'm not sure what these values really mean.
Make html a little bit cleaner.
shorten header width and use himan readble units. Leave maxtime empty if server has no limit Shorten header, use human readble units
please use 'monospace' instead of 'courier'. see bd8c963 |
We already show that information from the encapsulating context.
We want more space between the selector and the table
To prepare for further changes.
Instead of serif courier fonts use monospace. Make tables contents more readable.
donald
force-pushed
the
web-improvements
branch
from
November 9, 2016 10:18
bd8c963
to
27c1bbb
Compare
donald
force-pushed
the
web-improvements
branch
from
November 9, 2016 10:20
27c1bbb
to
2e4302d
Compare
Avoid killing the browser
We can select the pages via a header line now, so there is no need to have a separate selection page. Start with groups page right away.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wwwutz @arndt : I've tried to import your improvements. This is RFC only, please don't merge. We might want to change a bit here and there.
Demo-site: http://afk.molgen.mpg.de/mxq/mxq3/
What do you think?
Fixes: #48