Makefile: Allow lightweight tags in MXQ_VERSION_GIT #70
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we build from a git repository, the build system adds the output of
`git describe` to the version information.
However, per default `git describe` searches for annotated tags
only. Since version 0.22.5, we draft releases from github enterprise,
which creates lightweight tags. For this reason, the version string
ammendment was always based on the 0.22.4 release:
buczek@theinternet:~/git/mxq (master)$ ./mxqd --version
mxqd - MXQ v0.25.4 (beta) [0.22.4-134-g3ae9361]
by Marius Tolzmann <marius.tolzmann@molgen.mpg.de> 2013-2016
and Donald Buczek <buczek@molgen.mpg.de> 2015-2016
Max Planck Institute for Molecular Genetics - Berlin Dahlem
Add `--tags` to `git describe` so that the version string is based on
the newest tag.
mxqd - MXQ v0.25.4 (beta) [0.25.4-4-g3ae9361]
by Marius Tolzmann <marius.tolzmann@molgen.mpg.de> 2013-2016
and Donald Buczek <buczek@molgen.mpg.de> 2015-2016
Max Planck Institute for Molecular Genetics - Berlin Dahlem
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we build from a git repository, the build system adds the output of
git describeto the version information.However, per default
git describesearches for annotated tagsonly. Since version 0.22.5, we draft releases from github enterprise,
which creates lightweight tags. For this reason, the version string
ammendment was always based on the 0.22.4 release:
Add
--tagstogit describeso that the version string is based onthe newest tag.