Skip to content

mxqsub.c: Enforce usage of an unit, and explain it #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomas
Copy link
Contributor

@thomas thomas commented Mar 19, 2019

Since the default is described as '2G', a user can be mislead
to think gigabytes are the default unit (reasonable in 2019, or).

P.S. IMHO using these 'mimi-bytes' doesn't make it easier.

Since the default is described as '2G', a user can be mislead
to think gigabytes are the default unit (reasonable in 2019, or).

P.S. IMHO using these 'mimi-bytes' doesn't make it easier.
@thomas
Copy link
Contributor Author

thomas commented Mar 19, 2019

Well, maybe I should have squeezed in the information, that this issue is about specifying the job size :)

" [SIZE] may be suffixed with a combination of T, G and M\n"
" to specify tebibytes, gibibytes and mebibytes.\n"
" Defaults to mebibytes if no suffix is set.\n"
" [SIZE] To specify megabytes, gigabytes or terrabytes,\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give me a hint ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think of planets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which system?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something terestrial I guess ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, could be ...

@wwwutz
Copy link
Contributor

wwwutz commented Mar 19, 2019

  1. I don't see how this would make 'clear' anything clearer. I'm not allowed to specify --size=1024000000 anymore, since I'm forced to use M, G or T multiplier?

  2. It states '2G' as the default. I don't see, why anyone should think the default is "G". I would have asked what it was, when the default would have been stated as "2" . Assuming "G" is the default is ... not intelligent.

  3. There is a simple reason using mimi-bytes. Numbers and calculation and preventing discussion and standards. Not look&feel.

@thomas
Copy link
Contributor Author

thomas commented Mar 19, 2019

Cmon...
re1. will you ever use --size=1024000000 or --size=102400000 ? Where are your beloved separators?
re2. But the current default is M, where is this 'more' intelligent?
re3. This might dive into the region where people mutter about disk sizes (One of my favourite challanges on how to not start bashing others). Personally I like the way it is done in a popular command line utilty (ls):

SIZE  is  an integer and optional unit (example: 10M is 10*1024*1024).  Units are K, M, G, T, P, E, Z, Y (powers of 1024) or KB, MB, ... (powers of 1000).

@donald
Copy link
Contributor

donald commented Mar 20, 2019

But people might have submit scripts?

@thomas
Copy link
Contributor Author

thomas commented Mar 20, 2019

That's right, so if they did it the sloppy (clever?) way they will find a terse error message.
Should we discuss a 'migration' phase? No, please not :)

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants