Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
mxvipctl: Continue on error 
Fixes #3

If /etc/mxstartups contains invalid port numbers (e.g. out of range),
mxvipctl aborts and other services, which have valid entries, will
also not be started:

    buczek@theinternet:~/git/mxstartup ((06ba2f6...))$ grep theinternet /etc/mxstartups
    test1 theinternet - /bin/true -[80:4432423]
    test2 theinternet - /bin/true -[80:8080]
    buczek@theinternet:~/git/mxstartup ((06ba2f6...))$ sudo mxstartupctl start
    starting /run/mariux/mxvip.test1.cfg ..
    adding forward 141.14.31.7:80 <-> 141.14.31.7:4432423
    iptables v1.6.0: Port `4432423' not valid

    Try `iptables -h' or 'iptables --help' for more information.
    starting /run/mariux/mxservice.test1.cfg ..
    starting /run/mariux/mxservice.test2.cfg ..
    buczek@theinternet:~/git/mxstartup ((06ba2f6...))$

Remove `-e` option of the shell.
  • Loading branch information
@donald
donald committed Jan 4, 2019
1 parent 06ba2f6 commit 36e9774
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions mxvipctl
View file
Expand Up @@ -9,9 +9,6 @@ RUNDIR="/run/mariux"
# expands *-pattern in pathnames to null if no matching files are found..
shopt -s nullglob

# exit on any error
set -e

function mxvip_start_one() {
local vip=$1
local -i i mip mfwd
Expand Down

0 comments on commit 36e9774

Please sign in to comment.