Prepare p14 release #29

thomas · 2021-07-09T15:15:57Z

Name it "Radioactive Hybrid Terror Boar from Fukushima" ?

Since string.h is now included, there is no need to cope with strdup. (Except for keeping a monument from the 1994 code...)

The routine can be compacted a bit. - utilize the scan result from sscanf (as proposed) - no need to copy the input to a new buffer, since the parts of the path get 'strduped' in parse_entry

Breaking out with exit(0) is way QnD... This gives the chance to perform further cleanup when returned into main().

The original xdu used the right button to quit the application. The double-click variant brings the feature back.

donald

Excellent. "2 files changed, 147 insertions(+), 166 deletions(-)" . I love PRs which improve functionality AND make the code shorter at the same time.

thomas added 5 commits July 9, 2021 14:36

Remove clutter and tabs from c sources

49ed0ab

xdu.c: remove unneeded strdup definition

609498d

Since string.h is now included, there is no need to cope with strdup. (Except for keeping a monument from the 1994 code...)

xdu.c: improve file parser

468dc0c

The routine can be compacted a bit. - utilize the scan result from sscanf (as proposed) - no need to copy the input to a new buffer, since the parts of the path get 'strduped' in parse_entry

xwin.c: let us return from xmainloop()

8f58965

Breaking out with exit(0) is way QnD... This gives the chance to perform further cleanup when returned into main().

xwin.c: reenable mouse-quit

0db81cd

The original xdu used the right button to quit the application. The double-click variant brings the feature back.

donald approved these changes Jul 14, 2021

View reviewed changes

wwwutz merged commit a14e09c into master Jul 20, 2021

Prepare p14 release #29

Prepare p14 release #29

thomas commented Jul 9, 2021

donald left a comment

Prepare p14 release #29

Prepare p14 release #29

Conversation

thomas commented Jul 9, 2021

donald left a comment

Choose a reason for hiding this comment