Fix Clang warnings #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 4.0.0 shows the warnings below.
```
$ CC=clang make
clang -Wall -Werror -Wextra -pedantic -std=gnu99 -c -o xdu.o xdu.c
xdu.c:218:29: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
fprintf(stderr, usage);
^~~~~
xdu.c:218:29: note: treat the string as an argument to avoid this
fprintf(stderr, usage);
^
"%s",
xdu.c:226:25: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
fprintf(stderr, usage);
^~~~~
xdu.c:226:25: note: treat the string as an argument to avoid this
fprintf(stderr, usage);
^
"%s",
```
Clang 4.0.0 warns about the use of a possibly uninitialized variable.
```
$ CC=clang make
clang -Wall -Werror -Wextra -pedantic -std=gnu99 -c -o xdu.o xdu.c
xdu.c:887:5: error: variable 'name' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
default:
^~~~~~~
xdu.c:892:78: note: uninitialized use occurs here
fprintpstext(fp, rect.left + 4, rect.top + (rect.height - rect.top) / 2, name);
^~~~
xdu.c:868:28: note: initialize the variable 'name' to silence this warning
char label[1024], *name;
^
= NULL
1 error generated.
```
Only the function `a_saveps()` is the caller of that path, and passes
`res.showsize()`. Maybe that parameter should be checked by the caller
and an assert be added.
Setting the variable to NULl fixes the issue.
|
Thanks! |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly change the code to make Clang happy.