Skip to content

Commit

Permalink
* nis/nss_nis/nis-pwd.c (internal_nis_getpwent_r): Don't try to
Browse files Browse the repository at this point in the history
	free outkey in error case when batch_read is set.
  • Loading branch information
Ulrich Drepper committed May 1, 2006
1 parent d4b661e commit 1e528c6
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
3 changes: 3 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
2006-05-01 Ulrich Drepper <drepper@redhat.com>

* nis/nss_nis/nis-pwd.c (internal_nis_getpwent_r): Don't try to
free outkey in error case when batch_read is set.

* nis/nss_nis/nis-grp.c (internal_nis_getgrent_r): Don't try to
free outkey in error case when batch_read is set [Coverity CID 196].

Expand Down
6 changes: 4 additions & 2 deletions NEWS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GNU C Library NEWS -- history of user-visible changes. 2006-04-16
GNU C Library NEWS -- history of user-visible changes. 2006-05-01
Copyright (C) 1992-2002,2003,2004,2005,2006 Free Software Foundation, Inc.
See the end for copying conditions.

Expand All @@ -10,7 +10,9 @@ Version 2.5
* For Linux, the sorting of addresses returned by getaddrinfo now also
handles rules 3 and 7 from RFC 3484. Implemented by Ulrich Drepper.

* New Linux interfaces: splice, tee, sync_file_range.
* New Linux interfaces: splice, tee, sync_file_range, vmsplace.

* New iconv module for MIK. Contributed by Alexander Shopov.


Version 2.4
Expand Down
3 changes: 2 additions & 1 deletion nis/nss_nis/nis-pwd.c
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@ internal_nis_getpwent_r (struct passwd *pwd, char *buffer, size_t buflen,
errnop);
if (__builtin_expect (parse_res == -1, 0))
{
free (outkey);
if (!batch_read)
free (outkey);
*errnop = ERANGE;
return NSS_STATUS_TRYAGAIN;
}
Expand Down

0 comments on commit 1e528c6

Please sign in to comment.