Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
tst-malloc-thread-exit: Use fewer system resources
  • Loading branch information
Florian Weimer committed Feb 19, 2016
1 parent 3040149 commit 2a38688
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 14 deletions.
7 changes: 7 additions & 0 deletions ChangeLog
@@ -1,3 +1,10 @@
2016-02-19 Florian Weimer <fweimer@redhat.com>

* malloc/tst-malloc-thread-exit.c: Include test-skeleton.c early.
(do_test): Limit the number of arenas, so that we can use fewer
outer threads. Limit timeout to 3 seconds, in preparation for a
larger TIMEOUT value.

2016-02-19 Joseph Myers <joseph@codesourcery.com>

[BZ #19674]
Expand Down
29 changes: 15 additions & 14 deletions malloc/tst-malloc-thread-exit.c
Expand Up @@ -26,13 +26,17 @@
particularly related to the arena free list. */

#include <errno.h>
#include <malloc.h>
#include <pthread.h>
#include <stdbool.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>

#define TIMEOUT 7
static int do_test (void);

#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"

static bool termination_requested;
static int inner_thread_count = 4;
Expand Down Expand Up @@ -156,20 +160,20 @@ outer_thread (void *closure)
static int
do_test (void)
{
/* The number of top-level threads should be equal to the number of
arenas. See arena_get2. */
long outer_thread_count = sysconf (_SC_NPROCESSORS_ONLN);
if (outer_thread_count >= 1)
/* The number of threads should be smaller than the number of
arenas, so that there will be some free arenas to add to the
arena free list. */
enum { outer_thread_count = 2 };
if (mallopt (M_ARENA_MAX, 8) == 0)
{
/* See NARENAS_FROM_NCORES in malloc.c. */
if (sizeof (long) == 4)
outer_thread_count *= 2;
else
outer_thread_count *= 8;
printf ("error: mallopt (M_ARENA_MAX) failed\n");
return 1;
}

/* Leave some room for shutting down all threads gracefully. */
int timeout = TIMEOUT - 2;
int timeout = 3;
if (timeout > TIMEOUT)
timeout = TIMEOUT - 1;

pthread_t *threads = calloc (sizeof (*threads), outer_thread_count);
if (threads == NULL)
Expand Down Expand Up @@ -212,6 +216,3 @@ do_test (void)

return 0;
}

#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"

0 comments on commit 2a38688

Please sign in to comment.