Skip to content
Permalink
Browse files

CVE-2016-3075: Stack overflow in _nss_dns_getnetbyname_r [BZ #19879]

The defensive copy is not needed because the name may not alias the
output buffer.
  • Loading branch information...
Florian Weimer
Florian Weimer committed Mar 29, 2016
1 parent a603305 commit 317b199b4aff8cfa27f2302ab404d2bb5032b9a4
Showing with 8 additions and 4 deletions.
  1. +7 −0 ChangeLog
  2. +1 −4 resolv/nss_dns/dns-network.c
@@ -1,3 +1,10 @@
2016-03-29 Florian Weimer <fweimer@redhat.com>

[BZ #19879]
CVE-2016-3075
* resolv/nss_dns/dns-network.c (_nss_dns_getnetbyname_r): Do not
copy name.

2016-03-29 Florian Weimer <fweimer@redhat.com>

[BZ #19837]
@@ -118,17 +118,14 @@ _nss_dns_getnetbyname_r (const char *name, struct netent *result,
} net_buffer;
querybuf *orig_net_buffer;
int anslen;
char *qbuf;
enum nss_status status;

if (__res_maybe_init (&_res, 0) == -1)
return NSS_STATUS_UNAVAIL;

qbuf = strdupa (name);

net_buffer.buf = orig_net_buffer = (querybuf *) alloca (1024);

anslen = __libc_res_nsearch (&_res, qbuf, C_IN, T_PTR, net_buffer.buf->buf,
anslen = __libc_res_nsearch (&_res, name, C_IN, T_PTR, net_buffer.buf->buf,
1024, &net_buffer.ptr, NULL, NULL, NULL, NULL);
if (anslen < 0)
{

0 comments on commit 317b199

Please sign in to comment.
You can’t perform that action at this time.