Skip to content

Commit

Permalink
Use __volatile__ to access fpu control word
Browse files Browse the repository at this point in the history
  • Loading branch information
H.J. Lu committed Jun 18, 2012
1 parent 62c8cc6 commit 3ee947b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 5 deletions.
6 changes: 6 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2012-06-18 H.J. Lu <hongjiu.lu@intel.com>

[BZ #14117]
* sysdeps/x86_64/fpu_control.h (_FPU_GETCW): Add __volatile__.
(_FPU_SETCW): Likewise.

2012-06-15 H.J. Lu <hongjiu.lu@intel.com>

[BZ #14117]
Expand Down
19 changes: 14 additions & 5 deletions sysdeps/x86_64/fpu_control.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* FPU control word bits. x86-64 version.
Copyright (C) 1993,1995,1996,1997,1998,2000,2001,2002 Free Software Foundation, Inc.
/* FPU control word bits. x86 version.
Copyright (C) 1993-2012 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Olaf Flebbe.
Expand Down Expand Up @@ -90,9 +90,18 @@
/* Type of the control word. */
typedef unsigned int fpu_control_t __attribute__ ((__mode__ (__HI__)));

/* Macros for accessing the hardware control word. */
#define _FPU_GETCW(cw) __asm__ ("fnstcw %0" : "=m" (*&cw))
#define _FPU_SETCW(cw) __asm__ ("fldcw %0" : : "m" (*&cw))
/* Macros for accessing the hardware control word. "*&" is used to
work around a bug in older versions of GCC. __volatile__ is used
to support combination of writing the control register and reading
it back. Without __volatile__, the old value may be used for reading
back under compiler optimization.
Note that the use of these macros is not sufficient anymore with
recent hardware nor on x86-64. Some floating point operations are
executed in the SSE/SSE2 engines which have their own control and
status register. */
#define _FPU_GETCW(cw) __asm__ __volatile__ ("fnstcw %0" : "=m" (*&cw))
#define _FPU_SETCW(cw) __asm__ __volatile__ ("fldcw %0" : : "m" (*&cw))

/* Default control word set at startup. */
extern fpu_control_t __fpu_control;
Expand Down

0 comments on commit 3ee947b

Please sign in to comment.