Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Update.
2004-12-07  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/ia64/clone2.S (__clone2): Add support for
	NPTL where the PID is stored at userlevel and needs to be reset when
	CLONE_THREAD is not used.  Restore gp before calling _exit.
  • Loading branch information
Ulrich Drepper committed Dec 7, 2004
1 parent 2da9a6a commit 484cc80
Show file tree
Hide file tree
Showing 8 changed files with 57 additions and 5 deletions.
6 changes: 6 additions & 0 deletions ChangeLog
@@ -1,3 +1,9 @@
2004-12-07 Jakub Jelinek <jakub@redhat.com>

* sysdeps/unix/sysv/linux/ia64/clone2.S (__clone2): Add support for
NPTL where the PID is stored at userlevel and needs to be reset when
CLONE_THREAD is not used. Restore gp before calling _exit.

2004-12-07 Kaz Kojima <kkojima@rr.iij4u.or.jp>

* sysdeps/unix/sysv/linux/sh/clone.S: Clear the frame pointer when
Expand Down
10 changes: 10 additions & 0 deletions nptl/ChangeLog
@@ -1,3 +1,13 @@
2004-12-07 Jakub Jelinek <jakub@redhat.com>

* sysdeps/ia64/tcb-offsets.sym (TID): Add.
* sysdeps/unix/sysv/linux/ia64/clone2.S: New file.

* Makefile (tests): Add tst-getpid2.
* tst-getpid1.c (TEST_CLONE_FLAGS): Define.
(do_test): Use it. Use __clone2 instead of clone on ia64.
* tst-getpid2.c: New test.

2004-12-07 Kaz Kojima <kkojima@rr.iij4u.or.jp>

* sysdeps/unix/sysv/linux/sh/clone.S: New file.
Expand Down
2 changes: 1 addition & 1 deletion nptl/Makefile
Expand Up @@ -241,7 +241,7 @@ tests = tst-attr1 tst-attr2 tst-attr3 \
tst-backtrace1 \
tst-oddstacklimit \
tst-vfork1 tst-vfork2 tst-vfork1x tst-vfork2x \
tst-getpid1
tst-getpid1 tst-getpid2
xtests = tst-setuid1 tst-setuid1-static

# Files which must not be linked with libpthread.
Expand Down
1 change: 1 addition & 0 deletions nptl/sysdeps/ia64/tcb-offsets.sym
Expand Up @@ -2,5 +2,6 @@
#include <tls.h>

PID offsetof (struct pthread, pid) - sizeof (struct pthread)
TID offsetof (struct pthread, tid) - sizeof (struct pthread)
MULTIPLE_THREADS_OFFSET offsetof (struct pthread, header.multiple_threads) - sizeof (struct pthread)
SYSINFO_OFFSET offsetof (tcbhead_t, private)
2 changes: 2 additions & 0 deletions nptl/sysdeps/unix/sysv/linux/ia64/clone2.S
@@ -0,0 +1,2 @@
#define RESET_PID
#include <sysdeps/unix/sysv/linux/ia64/clone2.S>
14 changes: 13 additions & 1 deletion nptl/tst-getpid1.c
Expand Up @@ -5,6 +5,10 @@
#include <sys/types.h>
#include <sys/wait.h>

#ifndef TEST_CLONE_FLAGS
#define TEST_CLONE_FLAGS 0
#endif

static int sig;

static int
Expand Down Expand Up @@ -35,8 +39,16 @@ do_test (void)
return 1;
}

#ifdef __ia64__
extern int __clone2 (int (*__fn) (void *__arg), void *__child_stack_base,
size_t __child_stack_size, int __flags,
void *__arg, ...);
char st[256 * 1024];
pid_t p = __clone2 (f, st, sizeof (st), TEST_CLONE_FLAGS, 0);
#else
char st[128 * 1024];
pid_t p = clone (f, st + sizeof (st), 0, 0);
pid_t p = clone (f, st + sizeof (st), TEST_CLONE_FLAGS, 0);
#endif
if (p == -1)
{
printf("clone failed: %m\n");
Expand Down
2 changes: 2 additions & 0 deletions nptl/tst-getpid2.c
@@ -0,0 +1,2 @@
#define TEST_CLONE_FLAGS CLONE_VM
#include "tst-getpid1.c"
25 changes: 22 additions & 3 deletions sysdeps/unix/sysv/linux/ia64/clone2.S
Expand Up @@ -30,7 +30,7 @@

ENTRY(__clone2)
.prologue
alloc r2=ar.pfs,8,0,6,0
alloc r2=ar.pfs,8,1,6,0
cmp.eq p6,p0=0,in0
mov r8=EINVAL
mov out0=in3 /* Flags are first syscall argument. */
Expand Down Expand Up @@ -63,15 +63,34 @@ ENTRY(__clone2)
cmp.eq CHILD,PARENT=0,r8 /* Are we the child? */
(p6) br.cond.spnt.many __syscall_error
;;
(CHILD) ld8 out1=[in0],8 /* Retrieve code pointer. */
(CHILD) mov out0=in4 /* Pass proper argument to fn */
(CHILD) mov loc0=gp
(PARENT) ret
;;
#ifdef RESET_PID
tbit.nz p6,p0=in3,16 /* CLONE_THREAD */
tbit.z p7,p10=in3,8 /* CLONE_VM */
(p6) br.cond.dptk 1f
;;
mov r15=SYS_ify (getpid)
(p10) addl r8=-1,r0
(p7) break __BREAK_SYSCALL
;;
add r9=PID,r13
add r10=TID,r13
;;
st4 [r9]=r8
st4 [r10]=r8
;;
#endif
1: ld8 out1=[in0],8 /* Retrieve code pointer. */
mov out0=in4 /* Pass proper argument to fn */
;;
ld8 gp=[in0] /* Load function gp. */
mov b6=out1
br.call.dptk.many rp=b6 /* Call fn(arg) in the child */
;;
mov out0=r8 /* Argument to _exit */
mov gp=loc0
.globl HIDDEN_JUMPTARGET(_exit)
br.call.dpnt.many rp=HIDDEN_JUMPTARGET(_exit)
/* call _exit with result from fn. */
Expand Down

0 comments on commit 484cc80

Please sign in to comment.